Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reactivate tests in org.eclipse.core.tests.resources #525 #605

Conversation

Michael5601
Copy link
Contributor

@Michael5601 Michael5601 commented Jul 28, 2023

In this commit, the performance test from the Marker Test class in org.eclipse.core.tests.resources is reactivated because it can be run quickly and successfully. Contributes to #525

@Michael5601 Michael5601 changed the title Reactivate tests #525 Reactivate tests in org.eclipse.core.tests.resources #525 Aug 8, 2023
@Michael5601 Michael5601 force-pushed the PlatformResourcesPerformanceTests branch from f93e02c to 752e937 Compare August 8, 2023 08:25
…#525

In this commit, the performance test from the Marker Test class is reactivated because it can be run quickly and successfully.
Contributes to eclipse-platform#525
@Michael5601 Michael5601 force-pushed the PlatformResourcesPerformanceTests branch from 752e937 to a39bf90 Compare August 8, 2023 08:25
@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2023

Test Results

       42 files  +       2         42 suites  +2   1h 5m 8s ⏱️ + 11m 4s
  3 767 tests +       1    3 763 ✔️ ±       0    3 💤 ±0  1 +1 
11 304 runs  +1 038  11 276 ✔️ +1 037  27 💤 ±0  1 +1 

For more details on these failures, see this check.

Results for commit 9c4fca6. ± Comparison against base commit adca2ac.

♻️ This comment has been updated with latest results.

@Michael5601
Copy link
Contributor Author

The failing test is random failing test #488.

…#525

In this commit, the performance test from the Marker Test class is reactivated because it can be run quickly and successfully.
Contributes to eclipse-platform#525
@mickaelistria mickaelistria force-pushed the PlatformResourcesPerformanceTests branch from a39bf90 to 9c4fca6 Compare August 17, 2023 16:09
@HeikoKlare
Copy link
Contributor

The enabled method is no actual test method but only some code measuring and printing the time required for processing operations on markers. I gues it was used around 20 years ago when implementing the functionality to get some insights into the implementation's performance. I don't see that it still has any use but may only produce maintenance effort.

I would propose to change this PR (or replace it by a new one) so that the two _testPerformance* methods in the MarkerTest class are removed. @Michael5601 maybe you want to change it accordingly?

Michael5601 added a commit to CodeLtDave/eclipse.platform that referenced this pull request Sep 11, 2023
In this commit, the deactivated performance tests "_testPerformanceManyResources()"  and "_testPerformanceOneResource()" from MarkerTest.java in org.eclipse.core.tests.resources are deleted because they are not real test methods but rather used for code measuring and printing the time for processing operations on markers. See also eclipse-platform#605 (comment). Contributes to eclipse-platform#525
@Michael5601
Copy link
Contributor Author

The enabled method is no actual test method but only some code measuring and printing the time required for processing operations on markers. I gues it was used around 20 years ago when implementing the functionality to get some insights into the implementation's performance. I don't see that it still has any use but may only produce maintenance effort.

I would propose to change this PR (or replace it by a new one) so that the two _testPerformance* methods in the MarkerTest class are removed. @Michael5601 maybe you want to change it accordingly?

I have added a new PR with the requested changes. (See #674)
This PR will be closed now because it has been replaced with #674.

HeikoKlare pushed a commit to CodeLtDave/eclipse.platform that referenced this pull request Sep 11, 2023
In this commit, the deactivated performance tests "_testPerformanceManyResources()"  and "_testPerformanceOneResource()" from MarkerTest.java in org.eclipse.core.tests.resources are deleted because they are not real test methods but rather used for code measuring and printing the time for processing operations on markers. See also eclipse-platform#605 (comment). Contributes to eclipse-platform#525
HeikoKlare pushed a commit that referenced this pull request Sep 11, 2023
In this commit, the deactivated performance tests "_testPerformanceManyResources()"  and "_testPerformanceOneResource()" from MarkerTest.java in org.eclipse.core.tests.resources are deleted because they are not real test methods but rather used for code measuring and printing the time for processing operations on markers. See also #605 (comment). Contributes to #525
fedejeanne pushed a commit to fedejeanne/eclipse.platform that referenced this pull request Sep 13, 2023
In this commit, the deactivated performance tests "_testPerformanceManyResources()"  and "_testPerformanceOneResource()" from MarkerTest.java in org.eclipse.core.tests.resources are deleted because they are not real test methods but rather used for code measuring and printing the time for processing operations on markers. See also eclipse-platform#605 (comment). Contributes to eclipse-platform#525
fedejeanne pushed a commit to fedejeanne/eclipse.platform that referenced this pull request Sep 13, 2023
In this commit, the deactivated performance tests "_testPerformanceManyResources()"  and "_testPerformanceOneResource()" from MarkerTest.java in org.eclipse.core.tests.resources are deleted because they are not real test methods but rather used for code measuring and printing the time for processing operations on markers. See also eclipse-platform#605 (comment). Contributes to eclipse-platform#525
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants